Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed label for inputting API URL #3474

Merged
merged 1 commit into from
May 8, 2018
Merged

Conversation

Nazarah
Copy link
Contributor

@Nazarah Nazarah commented May 8, 2018

New value: API Host URL

Closes #3469

Changes

  • changed the label for API URL input in
    • Add New API page
    • Settings tab in API profile

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

New value: API Host URL
@Nazarah Nazarah requested a review from matleppa May 8, 2018 08:57
@ghost ghost assigned Nazarah May 8, 2018
@ghost ghost added the in progress label May 8, 2018
@matleppa matleppa merged commit 0627cb4 into develop May 8, 2018
@ghost ghost removed the Ready for review label May 8, 2018
@matleppa matleppa deleted the feature/change-api-url-label branch May 8, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants