Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved My APIs from APIs page to main menu #3503

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Moved My APIs from APIs page to main menu #3503

merged 4 commits into from
Jun 18, 2018

Conversation

vinaytech
Copy link
Collaborator

@vinaytech vinaytech commented Jun 7, 2018

Closes #3486

Changes

  • Moved MyAPI's tab from APIs page navigation bar to main header menubar.

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @matleppa

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@vinaytech vinaytech requested a review from matleppa June 12, 2018 07:48
@matleppa
Copy link
Member

matleppa commented Jun 12, 2018

@vinaytech
The problem here is that this PR now contains also same code, which was implemented in PR 3502, but without corrections done after review of that PR.

So let's make it this way:

  1. remove from here all code which is not related to this PR.
  2. make git rebase (so the corrected and merged functionality of PR 3502 is gotten from develop branch)

That way the PR contains only the new code which it is supposed to contain according to issue and there is no overlapping with other program code.

  • PR title needs revision

@matleppa matleppa changed the title Feature 3486 Moved My APIs from APIs page to main menu Jun 18, 2018
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@matleppa
Copy link
Member

Corrected the title.

@matleppa matleppa merged commit a80d835 into develop Jun 18, 2018
@ghost ghost removed the Ready for review label Jun 18, 2018
@matleppa matleppa deleted the feature-3486 branch June 18, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants