-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added field descriptions and placeholders in Add API fields #3512
Added field descriptions and placeholders in Add API fields #3512
Conversation
1. i18n.json: added templates addApi_nameFieldInfo, addApi_descriptionFieldInfo and addApi_urlFieldInfo which describe purpose of name, description and URL fields (respectively) in Add API page. 2. i18n.json: added template addApi_ownerHelpText that describes where an added API appears with what visibility. 3. add.html: added placeholders for fields name, description and url 4. add.html: added templates texts describing purpose of name, description and URL fields. 5. add.html: added template text describing where added API appears with what visibility. 6. add.less: added new css class field-description-text to style field description texts. 7. add.js: added constant variables to compare placeholder values from name, description and URL fields in add API page. 8. Added event listeners for click and blur events in name, description and url fields in Add API page.
1. add.js: added extra space before opening parenthesis in functions 2. add.js: removed unusued variable "event" from functions. 3. add.js: used '' instead "" for strings. 4. add.js and add.html: changed placeholder string to make it smaler in order to accommodate travis build passing.
1. add.js and add.html: changed placeholder message for description field.
1. add.js and add.html: changed placeholder string for description field
add.js: added value of apiDescriptionFieldValue within tild symbols instead single quotes.
1. add.js: removed trailing spaces in line 20 and 21
add.js: removed trailing space from line 21:49
1. schema.js: added placeholder values for fields Name, Description and URL 2. add.html: removed placeholder values for Name, Description and URL from fieldsets 3. add.js: removed variables containing placeholder values for Name, Description and URL 4. Removed redundant event handlers for click and blur events in Name, Description and URL.
1. schema.js: added quotes within single quotes instead double quotes. 2. schema.js: reduced characters in a single line within 100 in placeholder values.
schema.js: added quotes within '' instead "" in line 41.
I'd suggest the description texts to be moved above the input field in order to keep them visible also in case the browser generates and adds a drop-down menu into input field. |
@matleppa let's not do it. Ecstatically it looks better as it's now. Help text != description (which has to go after title). |
@matleppa before adding the templates to show help texts, the code used to be like the following:
It means the fields are being populated using the Autoform package. |
@55 OK, we can call it help text instead of description. It seems that in this very case there are some challenges because of use of afQuickField. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
Closes #3403
Changes
i18n.json: added templates
addApi_nameFieldInfo
,addApi_descriptionFieldInfo
andaddApi_urlFieldInfo
which describe purpose of name, description and URL fields (respectively) in Add API page.i18n.json: added template
addApi_ownerHelpText
that describes where an added API appears with what visibility.schema.json: added placeholder values under autoform attribute for Name, Description and URL fields.
add.html: added templates texts describing the purpose of name, description and url fields.
add.html: added template text describing where added API appears with what visibility.
add.less: added new css class
field-description-text
to style field description texts.Developer checklist
This checklist is to be completed by the PR developer:
Reviewer checklist
Reviewed by: @username1
This list is to be completed by the pull request reviewer: