Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation round changes #3518

Merged
merged 4 commits into from
Jul 4, 2018
Merged

Translation round changes #3518

merged 4 commits into from
Jul 4, 2018

Conversation

preriasusi
Copy link
Contributor

Closes #3517

Changes

Describe your changes here as a bulleted list:

  • change one
  • change two

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned preriasusi Jun 29, 2018
@ghost ghost added the in progress label Jun 29, 2018
@preriasusi preriasusi changed the title Updating texts for API monitoring Translation round changes Jul 2, 2018
Copy link
Member

@ilarimikkonen ilarimikkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monitoring is a highly recommended functionality you should keep enabled. Let API Management perform health check on your API. API monitoring is done using HTTP requests. Choose one of your API's GET method to prevent accidental data insertion/modification. When monitoring is set up, you will see a dot next to your API name indicating the health of your API based on calls made in monitoring. Green = OK, Red = not OK",

Copy link
Member

@ilarimikkonen ilarimikkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approvado

Copy link
Member

@ilarimikkonen ilarimikkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again

@ilarimikkonen ilarimikkonen merged commit f51668a into develop Jul 4, 2018
@ghost ghost removed the Ready for review label Jul 4, 2018
@ilarimikkonen ilarimikkonen deleted the localisation_fixes branch October 16, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants