Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger editor #356

Merged
merged 13 commits into from
Aug 13, 2015
Merged

Swagger editor #356

merged 13 commits into from
Aug 13, 2015

Conversation

JuusoV
Copy link
Contributor

@JuusoV JuusoV commented Aug 12, 2015

Integrated Swagger editor with iframe

@JuusoV JuusoV changed the title Added route and implemented swagger editor with iframe Swagger editor Aug 12, 2015
@@ -0,0 +1,3 @@
<template name="editor">
<iframe src="http://editor.apinf.io:49160" width="100%" id="swagger-editor"></iframe>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iframe src is currently hard-coded with our domain name and port. Move these into the config.json file for now, so that the swagger editor can run on any server deployment.

@brylie
Copy link
Contributor

brylie commented Aug 13, 2015

This pull request contains only one commit, but two files were edited. In general, strive to separate commits describing each significant file change.

@JuusoV
Copy link
Contributor Author

JuusoV commented Aug 13, 2015

Made changes as per @brylie suggested.

brylie added a commit that referenced this pull request Aug 13, 2015
@brylie brylie merged commit b64d4c3 into develop Aug 13, 2015
@brylie brylie deleted the feature/swagger-editor branch August 13, 2015 12:49
@bajiat bajiat mentioned this pull request Feb 6, 2017
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants