Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outcommented adding meta info for API name and description (on top 0.56.0) #3603

Merged
merged 4 commits into from
Oct 29, 2018

Conversation

matleppa
Copy link
Member

Changes

Describe your changes here as a bulleted list:

  • change one
  • change two

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned matleppa Oct 29, 2018
@ghost ghost added the in progress label Oct 29, 2018
@matleppa matleppa changed the title Outcommented adding meta info for API name and description Outcommented adding meta info for API name and description (on top 0.56.0) Oct 29, 2018
@matleppa matleppa merged commit 333b1bb into develop Oct 29, 2018
@ghost ghost removed the in progress label Oct 29, 2018
@ilarimikkonen ilarimikkonen deleted the on-top-0-56-0-by-outcomment branch November 30, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant