Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/heapmap refresh #378

Merged
merged 30 commits into from
Aug 17, 2015
Merged

Feature/heapmap refresh #378

merged 30 commits into from
Aug 17, 2015

Conversation

frenchbread
Copy link
Contributor

No description provided.

@frenchbread
Copy link
Contributor Author

@apinf/developers Finally issue #322 is resolved. Now, map with heat points should update after any interaction with dashboard: on charts (if selecting specific time range) and when filtering by specific month, year & points limit.

Please review, test and merge.

// set an autorun function
instance.autorun(function () {

console.log("Autorun ->");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup.

"change #filteringForm" : function(e){
"change #filteringForm" : function(event, template){

var instance = Template.instance();

// appending loading state
$('#loadingState').html("Loading...");

console.log("Changed");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup.

// function that parses map
instance.parseMapData = function (data) {

var mapData = data;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps rename the input variable to 'mapData', and this line is unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

brylie added a commit that referenced this pull request Aug 17, 2015
@brylie brylie merged commit 770f458 into develop Aug 17, 2015
@brylie brylie deleted the feature/heapmap-refresh branch August 17, 2015 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants