Feature/apiBackend status #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
To be able to test it, navigate |
| Template.viewApiBackend.rendered = function () { | ||
|
|
||
| // fetches current apiBackend | ||
| var apiBackend = ApiBackends.find().fetch(); |
There was a problem hiding this comment.
Fetch only one API Backend. E.g. ApiBackends.findOne(instance.apiBackendId);
There was a problem hiding this comment.
@brylie Changing this one to .findOne( ) - because in this context meteor will fetch single apiBackend data anyway. By the way backendId comes as undefined in Template.viewApiBackend.created.
|
@brylie All suggested changes are on place now. Please review. |
|
UI looks good for me @brylie if everything else if alright, merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @apinf/developers. Please review this PR.