Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/apibackend form hints #479

Merged
merged 26 commits into from
Oct 21, 2015
Merged

Feature/apibackend form hints #479

merged 26 commits into from
Oct 21, 2015

Conversation

55
Copy link
Contributor

@55 55 commented Sep 25, 2015

Closes #427, #431

@brylie
Copy link
Contributor

brylie commented Sep 29, 2015

Status update?

elnzv added 2 commits October 1, 2015 09:25
Merge remote-tracking branch 'origin/develop' into feature/apibackend…
e984885 
…-form-hints

Conflicts:
	client/views/api_backends/api_backends.html
missing ;
1fc9835
@55
Copy link
Contributor Author

55 commented Oct 1, 2015

Fixed conflicts.
Needed a pair programming session with @apinf/developers to place hints' text.

@brylie
Copy link
Contributor

brylie commented Oct 1, 2015

One last change is to add "'InlineHelp": false to the .jshintrc file under the // Apinf packages section.

@55 55 added WIP and removed WIP labels Oct 7, 2015
@55 55 removed the WIP label Oct 14, 2015
@55
Copy link
Contributor Author

55 commented Oct 14, 2015

Closes #427
@apinf/developers, please review amd merge.

@bajiat bajiat added the WIP label Oct 16, 2015
@55 55 removed the WIP label Oct 20, 2015
@55
Copy link
Contributor Author

55 commented Oct 20, 2015

New hints' text added.
WIP removed and PR is ready to be reviewed and merged.
@apinf/developers, please review it ASAP.

frenchbread
frenchbread reviewed Oct 20, 2015
View reviewed changes
client/views/api_backends/form_hints/form_hints.js
}
},
'http_basic_auth': {
message: "Does your api need a username and password for access? If yes, the must be specified here.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in second sentence. I think it should be they rather than the.

@frenchbread
Copy link
Contributor

@elnzv looks good! But found some issues:

  • Can this design issue be fixed to be like inline or with paddings from top and right?

    screen shot 2015-10-20 at 18 27 31

  • Typo in client/views/api_backends/form_hints/form_hints.js 69 line

  • Also found out that some fields do not have inline help support. Fields like required_roles, rate_limit_mode and others .. Is that a bug or a feature?

@bajiat
Copy link
Contributor

bajiat commented Oct 20, 2015

@elnzv Is there any easy way for me to see the texts in the actual form?

@55
Copy link
Contributor Author

55 commented Oct 20, 2015

@bajiat, I have just copied text from Aseem's letter.
Here are the list of them - https://github.com/apinf/api-umbrella-dashboard/blob/feature/apibackend-form-hints/client/views/api_backends/form_hints/form_hints.js

@55
Copy link
Contributor Author

55 commented Oct 20, 2015

@frenchbread, fixed typo, added padding, yes, for now these are only available hints, further on we can add new or change existing ones.

@frenchbread
Copy link
Contributor

@elnzv Thanks for fixes. Merging..

frenchbread added a commit that referenced this pull request Oct 21, 2015
@frenchbread
Merge pull request #479 from apinf/feature/apibackend-form-hints
7b9b310 
Feature/apibackend form hints
@frenchbread frenchbread merged commit 7b9b310 into develop Oct 21, 2015
@frenchbread frenchbread deleted the feature/apibackend-form-hints branch October 21, 2015 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@55 @brylie @frenchbread @bajiat