Add error treatment to apiUmbrellaWeb[...].createApiBackend - closes #357

[mauriciovieira]

@elnzv or @frenchbread please 🔍

[55]

1. Error message disappears too fast, extend time of showing or leave message until user closes it.
2. It is not clear that there is a check after submission - form is cleaned and only after couple seconds error message is showing. I think we need to put a loading icon or some indication that the form is submitting.
3. If there is an error - form is cleaned, I think we need to keep it and just indicate the field which causing the error.

If I get an error, server console says this:

What is this [object Object]?

[mauriciovieira]

1. Ok, I'll do this.
2. This happens because first autoform inserts the new API to meteorjs mongo db and then we try to insert it in the API Umbrella through brylie:api-umbrella rest-client package. I agree with the loading icon and will do this ASAP.
3. Yeah, I didn't not research how to send the errors back to the client, manually, without the autoform magic. I hope it is not impossible, or we would have to abdicate the use of autoform in this complex screen.
4. I removed that unuseful Return response ... log.

[55]

@mauriciovieira, let me know when PR is ready to be reviewed by removing WIP label.

[mauriciovieira]

@bajiat I am trying to fix this as @elnzv commented.

[brylie]

We might need to change this to use before or onSubmit AutoForm hooks, so that we can validate the API Umbrella response.

[mauriciovieira]

The problem here is that I am afraid we might not have the apiBackend saved in mongoDB prior sending it to api umbrella. I will try this

[55]

@mauriciovieira here is one approach to show that form is submitting:

AutoForm.hooks({
  apiBackends: {
    beginSubmit: function () {
      // Disable form elements while submitting form
      $('[data-schema-key],button').attr("disabled", "disabled");
    },
    endSubmit: function () {
      // Enable form elements after form submission
      $('[data-schema-key],button').removeAttr("disabled");
    }
  }
});

It simply disables all fields during the submission.

[mauriciovieira]

@elnzv @brylie thank you guys for the tips. I already added some fixes to the code.

[brylie]

I note that there are two objects in you examples:

{
  default: {} 
}

{
  errors: {} 
}

What is the difference that causes the object to sometimes be named default and other times be named errors?

[mauriciovieira]

@brylie, it is not:

{
  default: {} //object
}

but

{
  default: 'string with errors' 
}

That means, all we get from apiUmbrellaWeb.adminApi.v1.apiBackends.createApiBackend(constructedBackend); is a string, the error.message. As it is not treating the error and returning a json object, but only a string while brylie:api-umbrella issue#1 is not resolved. After it is resolved, we might get a json object

{
  errors: {} 
}

with the errors for each.

So, the format

{
  errors: {} 
}

is never returned untill we fix the meteor-package error handling.

[brylie]

@elnzv please review again. @mauriciovieira and I did pair programming over the past two days to get things working.

[brylie]

Cleanup comment

[brylie]

Give a more meaningful comment here. E.g. 'submit the form on success'