-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pass api key to swagger - closes #76 #534
Conversation
#76 related issue. @apinf/developers Please review |
@@ -29,6 +29,17 @@ Template.documentation.events({ | |||
|
|||
// Set Swagger document URL to selected value | |||
instance.swaggerDocumentUrl.set(event.target.value); | |||
}, | |||
'load #documentation': function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to adhere to some conventions, like use ' or " to name the events.
As the other events and helpers are using ", I suggest replacing ' for ".
After these tiny changes, 👍, feel free to merge. |
@mauriciovieira Thanks! |
Feature/pass api key to swagger - closes #76
@mauriciovieira is there any way I can help here? |
@brylie I think it is done |
@brylie Actually I came up with better solution for this issue after stated working on #517. In
This would be the best place to preload user's api key. The thing is that Swagger UI is currently loaded using iframe in
Meaning that file In addition, it would be also possible to change |
No description provided.