Feature/536 download api usage - closes #536 #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchbread
changed the title
5 tasks
|
This PR looks great. It has clean code, meaningful comments, and descriptive commit messages. |
| @@ -2,6 +2,7 @@ | |||
| <div class="box box-primary" id="filter-box"> | |||
| <div class="box-header with-border"> | |||
| <h3 class="box-title">{{_ "filterData-Title"}}</h3> | |||
| <a class="btn btn-default btn-xs" id="downloadUsageLogs" style="float:right">Export logs in .csv</a> | |||
There was a problem hiding this comment.
Move style property to style file.
There was a problem hiding this comment.
There is a Bootstrap helper class for this:
<a class="btn btn-default btn-xs pull-right"...></a>Also, why is the anchor tag used here? It would be more semantic to simply use the <button> tag here.
There was a problem hiding this comment.
Also, please rename the button ID to use hyphenation:
<a ... id="download-usage-logs"></a>We are using hyphenation for the majority of our class and id declarations, and want to stay consistent.
55
pushed a commit
that referenced
this pull request
Nov 4, 2015
Feature/536 download api usage - closes #536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apinf/developers please review. #536 related