Feature/update brylie meteor api umbrella. Closes #591

[brylie]

@apinf/developers please review carefully. I have updated the API Umbrella integration plugin, and made changes to our code to use the new interface. Please help test this to avoid breaking changes.

[bajiat]

@mauriciovieira Would you please review this PR?

[mauriciovieira]

@bajiat yes!

[mauriciovieira]

Why not also add a settings.json.example file to the project?

[brylie]

OK, done. I misunderstood your comment initially.

[mauriciovieira]

sorry, I meant 'adding'.

[mauriciovieira]

@bajiat, @brylie, due to apinf/meteor-api-umbrella#5, I think this review has to wait.

[mauriciovieira]

@baijat, @brylie apinf/meteor-api-umbrella#6 should be accepted and the new version installed to api-umbrella-dashboard. Then the application should work smoothly and this PR will be ok. I will test tomorrow.

[mauriciovieira]

this should be 1.0.1

[mauriciovieira]

@brylie I am getting an error on syncApiBackends function triggered at startup.

W20151118-09:56:00.442(-2)? (STDERR)
W20151118-09:56:00.444(-2)? (STDERR) /Users/mauricio/.meteor/packages/meteor-tool/.1.1.10.10lkrly++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:245
W20151118-09:56:00.444(-2)? (STDERR)                        throw(ex);
W20151118-09:56:00.444(-2)? (STDERR)                              ^
W20151118-09:56:00.444(-2)? (STDERR) Error: Invalid characters. Only 0-9 characters are allowed.
W20151118-09:56:00.444(-2)? (STDERR)     at getErrorObject (packages/aldeed_collection2/packages/aldeed_collection2.js:425:1)
W20151118-09:56:00.444(-2)? (STDERR)     at [object Object].doValidate (packages/aldeed_collection2/packages/aldeed_collection2.js:408:1)
W20151118-09:56:00.444(-2)? (STDERR)     at [object Object].Mongo.Collection.(anonymous function) [as insert] (packages/aldeed_collection2/packages/aldeed_collection2.js:177:1)
W20151118-09:56:00.444(-2)? (STDERR)     at server/methods/apiBackends.js:15:1
W20151118-09:56:00.444(-2)? (STDERR)     at Array.forEach (native)
W20151118-09:56:00.444(-2)? (STDERR)     at Function._.each._.forEach (packages/underscore/underscore.js:105:1)
W20151118-09:56:00.444(-2)? (STDERR)     at [object Object].Meteor.methods.syncApiBackends (server/methods/apiBackends.js:9:1)
W20151118-09:56:00.445(-2)? (STDERR)     at maybeAuditArgumentChecks (livedata_server.js:1698:12)
W20151118-09:56:00.445(-2)? (STDERR)     at livedata_server.js:1611:18
W20151118-09:56:00.445(-2)? (STDERR)     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
W20151118-09:56:00.445(-2)? (STDERR)     at [object Object]._.extend.apply (livedata_server.js:1610:45)
W20151118-09:56:00.445(-2)? (STDERR)     at [object Object]._.extend.call (livedata_server.js:1553:17)
W20151118-09:56:00.445(-2)? (STDERR)     at server/startup.js:26:1
W20151118-09:56:00.445(-2)? (STDERR)     at /Users/mauricio/Repositories/github.com/apinf/api-umbrella-dashboard/.meteor/local/build/programs/server/boot.js:249:5
=> Exited with code: 8

after meteor reset it is still happening and I don't have a clue of why the collection is not inserting the apiBackend. Maybe it is a data error from the endpoint, but I could not debug since meteor shell is not working because the application does not start.

Are you getting the same error?

[brylie]

We can debug by console logging the API Backend instead of inserting it into the database, within the syncApiBackends method.

[brylie]

It looks like there is an entry in API Umbrella with a zero for port number, within the servers array:

{ [Error: Invalid characters. Only 0-9 characters are allowed. [400]]
      error: 400,
      reason: 'Invalid characters. Only 0-9 characters are allowed.',
      details: '[{"name":"servers.0.port","type":"regEx","value":"0"}]',
      message: 'Invalid characters. Only 0-9 characters are allowed. [400]',
      errorType: 'Meteor.Error' } }
 =======================
 { backend_host: 'umbrella.apinf.io',
   backend_protocol: 'http',
   balance_algorithm: 'least_conn',
   created_at: Mon Nov 16 2015 12:09:51 GMT+0200 (EET),
   created_by: '29be177c-865b-4dcb-ad2e-49670d7a19ec',
   frontend_host: 'books.googleapis.com',
   name: 'Test_google_books',
   servers: [ { host: 'books.googleapis.com', port: '0' } ],
   settings: 
   { default_response_headers_string: 'Access-Control-Allow-Origin: *',
      override_response_headers_string: 'Access-Control-Allow-Origin: *' },
   sort_order: 29,
   updated_at: Mon Nov 16 2015 12:09:51 GMT+0200 (EET),
   updated_by: '29be177c-865b-4dcb-ad2e-49670d7a19ec',
   url_matches: [ { backend_prefix: '/', frontend_prefix: '/test_api4/g/books' } ],
   version: 1,
   id: '0304b666-9f56-4738-8e09-8e4c94a4f795',
   managerIds: [ null ] }

I am not sure how this was entered into the system, but the issue should resolve if we delete the backend from API Umbrella.

[brylie]

Basically, our regExp for port number looks for 2-5 numeric characters, while API Umbrella seems to allow any Numeric value.

[brylie]

@elnzv do you recall where you entered this API Backend (API Umbrella or Apinf)? I am trying to figure out how port zero passed validation.

[mauriciovieira]

@brylie ok, if it is a data problem that might happen again, another solution is to treat the error and ignore the faulty apiBackend that comes back from the rails umbrella endpoint. Imagine a client that has an old api-umbrella installation, with buggy endpoints inserted, and want to plug our dashboard on top of it. Is that a impossible corner-case?

[mauriciovieira]

apinf/api-umbrella-dashboard@ef21d86 is what I meant with treat the error

[brylie]

We can ignore the faulty api backend, but it should not fail silently. I.e. we need to at least log somewhere that the backend was rejected, so the administrator is aware and can troubleshoot.

[brylie]

@mauriciovieira is there any more work needed before this PR can be merged? Is the error treatment taking place in another task?

[mauriciovieira]

@brylie I believe this PR can be merged. #636 fixes it, using console.error to log (by now).