Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/unify api forms #660

Merged
merged 24 commits into from
Dec 1, 2015
Merged

Feature/unify api forms #660

merged 24 commits into from
Dec 1, 2015

Conversation

55
Copy link
Contributor

@55 55 commented Nov 27, 2015

Closes #368

elnzv and others added 21 commits November 19, 2015 05:12
changed formType conditionally
73b3d81
clean up
4510e05
check for router id and change formType
e4859b6
refactore apiBackend route
6293998
changed to formType
6fae447
renamed template moved to new folder
8c609cd
renamed template
fc20aa5
refactore editApiBackend
81e6e1e
added subscription
fe400dd
renamed subscription (temporarily)
d0d1761
Merge remote-tracking branch 'origin/develop' into feature/unify-api-…
2cfed2d 
…forms
@brylie
Fix formType helper
4436095
@brylie
Add template level subscription parameter
e9957b8
@brylie
Add apiBackend helper
12ea01e
@brylie
Change form ID to apiBackendForm
7897adc
@brylie
Get apiBackendId from current document
5ae749f
@brylie
Cleanup router level subscription and data
303ffba
@brylie
Cleanup console log
428d7c4
added edit API title
d4cbe28
editMode helper to show relevant title
2e4d8be
new variables
a3fc7d2
@55 55 added the in progress label Nov 27, 2015
@brylie brylie self-assigned this Nov 27, 2015
@55
Copy link
Contributor Author

55 commented Nov 27, 2015

@mauriciovieira and/or @frenchbread, could you please review this PR, since we were working on it together with Brylie?

@55 55 unassigned brylie Nov 27, 2015
@jykae
Copy link
Contributor

jykae commented Nov 27, 2015

@elnzv @brylie Will this fix issue https://github.com/apinf/api-umbrella-dashboard/issues/602 ? In version 0.1.0 the labels for Backend host & Frontend host should be switched, otherwise they go wrong when backend is sent to Umbrella.

@frenchbread
Copy link
Contributor

Found an issue:

If current user does not have a permission to edit an apiBackend -> page counties to load and no error (e.g. 404) is given.

If a backend, to which user is trying to navigate does not exist, error is also not given. Page infinitely continues to load.

@elnzv Could this one be fixed?

@frenchbread
Copy link
Contributor

Code looks good though!

@55
Copy link
Contributor Author

55 commented Dec 1, 2015

@frenchbread, same issue in develop branch.
I think we need to create a separate issue for this.

@frenchbread
Copy link
Contributor

Ok then. Merging this.

frenchbread added a commit that referenced this pull request Dec 1, 2015
@frenchbread
Merge pull request #660 from apinf/feature/unify-api-forms
56c90fe 
Feature/unify api forms
@frenchbread frenchbread merged commit 56c90fe into develop Dec 1, 2015
@frenchbread frenchbread deleted the feature/unify-api-forms branch December 1, 2015 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frenchbread frenchbread

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@55 @jykae @frenchbread @brylie