Feature/admin settings page

[55]

Closes #327

[jykae]

Getting type errors to console are confusing when starting the application.
Also there are TODO's remaining in the code.

As for the Settings page, imho, and admin user experience, if it's possible to get current URL where application is running("Host") and for Umbrella settings, I would like enter only the Umbrella URL and API key/token information.

Possibly redirect to Settings page if we are getting undefined settings values in the startup.
However the requirements for this task are met. Could have been split to redesigning settings & implementing Settings page.

I will open up suggestion for redesigning settings.

[jykae]

Cannot enter localhost with port.

[jykae]

Cannot merge this yet. Let's look this together @elnzv and @brylie

[brylie]

Ah, interesting. We need to figure out if port is a requirement of this task.

[brylie]

In fairness here, we are using the SimpleSchema URL RegEx. URL regular expressions are typically complex, and might add undue complexity to this task.

Here are a couple of other possibilities we can pursue:

• File an upstream feature request that URL RegEx support port number
• Refactor the API Umbrella settings object to break the URL into components
  • base url
  • port
  • path

[bajiat]

@jykae has promised to make the changes

[brylie]

Cool. For a simple solution, we can just remove the URL Regex. However, then we are not guaranteed to have a valid URL, since there will be no validation.

[jykae]

Looks like Illya already removed the validation regex after my prev. testing, so this seems to work now, as the validation is removed from URL. Though I had chat today with @brylie in Skype and we decided to fix it rather than remove the check.

The planned fix is to add field for the port number to settings schema and keep the regex for URL.

EDIT: The port is not actually the issue here, but using "localhost". Validation is expecting REAL URL. Port numbers work with other URLs. My suggestion would be that we add the regex back, and I solve the conflict here.

I will make "enhancement" issue about this, but this is quite minor detail and only affects developers. If starting app with settings.json like before, using "localhost" in Apinf host URL works. And for development it should be fine. For UX when setting up Apinf first time or for production, having settings page is great.

[jykae]

Minor enhancement issue opened: https://github.com/apinf/api-umbrella-dashboard/issues/734

[brylie]

@jykae good catch. I didn't realize 'localhost' was causing the regex to fail.