Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [Frontend prefix] sample path - closes #679 #699

Merged
merged 3 commits into from
Dec 9, 2015

Conversation

frenchbread
Copy link
Contributor

No description provided.

@frenchbread
Copy link
Contributor Author

@brylie Please review. #679 related.

@@ -2,7 +2,7 @@
<div id="usage-instructions" class="collapse alert alert-info">
<i class="fa fa-info-circle fa-5x pull-left"></i>
<p>Make API calls to: <br />
<em>{{ apiUmbrellaBaseUrl }}[Frontend prefix]</em>
<em>{{ apiUmbrellaBaseUrl }}</em>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the text [frontend prefix] to remain in the help section. What we do not want is for the /api-umbrella to be part of the URL.

Specifically, when users make API calls to API Umbrella, they use the following URL structure:

http://umbrella.apinf.io/[frontend prefix]

Our documentation is incorrect in including /api-umbrella as part of the URL.

@frenchbread
Copy link
Contributor Author

Added changes.

brylie added a commit that referenced this pull request Dec 9, 2015
Remove [Frontend prefix] sample path - closes #679
@brylie brylie merged commit 65c09d9 into develop Dec 9, 2015
@brylie brylie removed the in progress label Dec 9, 2015
@brylie brylie deleted the hotfix/url-in-usage-instructions branch December 9, 2015 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants