Feature/641 api feedback voting. Closes #641 #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 8, 2015 15:23
|
Closes #641 |
| 'sumOfVotes': function () { | ||
| //Adds all vote integers together, returns sum of all votes as Integer | ||
| var feedbacks = FeedbackVotes.find({feedbackId: this._id}).fetch(); | ||
| var votes = _(feedbacks).map(function(feedback){ |
There was a problem hiding this comment.
Add line comment here. E.g.:
// Create list of all feedback vote values
|
Overall, great work @jykae! Mainly, this is lacking line comments. There are also a few significant pieces to the feature, that are now better outlined in the definition of done. |
|
Also, change the mouse cursor to a pointer |
brylie
changed the title
added 6 commits
December 14, 2015 09:22
…o feature/641-api-feedback-voting
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic functionality of feedback voting.