Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/701 no anonymous ratings. Closes #701 #705

Merged
merged 6 commits into from
Dec 11, 2015

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Dec 9, 2015

No description provided.

@brylie brylie added this to the Sprint 18 milestone Dec 9, 2015
@55 55 self-assigned this Dec 10, 2015
@55
Copy link
Contributor

55 commented Dec 11, 2015

When anonymous user votes starts are still changing.
Even if results are not saved, visually it looks so.

701

I think visual part of voting should be disabled for anonymous user too.

@brylie
Copy link
Contributor Author

brylie commented Dec 11, 2015

OK, I updated the code to be read only if user is not logged in. Good catch.

55 pushed a commit that referenced this pull request Dec 11, 2015
Feature/701 no anonymous ratings. Closes #701
@55 55 merged commit a97671d into develop Dec 11, 2015
@55 55 removed the in progress label Dec 11, 2015
@55 55 deleted the feature/701-no-anonymous-ratings branch December 11, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants