Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/api backlog - closes #518 #757

Merged
merged 106 commits into from
Jan 21, 2016
Merged

Feature/api backlog - closes #518 #757

merged 106 commits into from
Jan 21, 2016

Conversation

frenchbread
Copy link
Contributor

@apinf/developers Please review. Closes #518.

@brylie
Copy link
Contributor

brylie commented Jan 20, 2016

This seems ready for review/merge. @jykae will you please review?

@jykae
Copy link
Contributor

jykae commented Jan 20, 2016

I noticed couple of bugs. @brylie started to fix them.

  1. Cannot remove Backlog item.
    Uncaught TypeError: Cannot read property '_id' of undefined
  2. When editing item I would expect to have existing data in the form, now it is empty after creating one.
  3. Admin should be able to modify all API backlogs, currently only API manager is able to edit. Anonymous user should not be able to edit API backlogs.

@frenchbread
Copy link
Contributor Author

@brylie Looks good! Thanks for integrating it yourself.

Still there is an Add backlog item button on a apiBackend page that current user is not managing. I think it's not supposed to be there. Do you want me to add a check for it?

@frenchbread
Copy link
Contributor Author

Agreed with @jykae about not able to edit backlog item

@frenchbread
Copy link
Contributor Author

As I understand, @jykae, you are fixing it right now? Asking so that we are not messing up the commits here.

@brylie
Copy link
Contributor

brylie commented Jan 20, 2016

@frenchbread are you available for a chat?

@frenchbread
Copy link
Contributor Author

@brylie Yep!

@brylie
Copy link
Contributor

brylie commented Jan 20, 2016

We are really close to having things working. The main challenge currently is that the Edit and Delete buttons are not working correctly after refactoring.

Lets chat in appear.in

@brylie
Copy link
Contributor

brylie commented Jan 20, 2016

@frenchbread I have working changes. I will commit the changes now.

@frenchbread
Copy link
Contributor Author

@brylie Tested - all permission checks are on place now. Works for me.

@jykae Would you also review this one?

@jykae
Copy link
Contributor

jykae commented Jan 21, 2016

@frenchbread @brylie Reviewing now.

@jykae
Copy link
Contributor

jykae commented Jan 21, 2016

Verified: Issues fixed and permissions work. Great!

jykae pushed a commit that referenced this pull request Jan 21, 2016
@jykae jykae merged commit 5393cce into develop Jan 21, 2016
@jykae jykae deleted the feature/api-backlog branch January 21, 2016 08:16
@jykae jykae removed the in progress label Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants