Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/api metadata i18n. Closes #779 #825

Merged
merged 5 commits into from
Feb 4, 2016
Merged

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Feb 1, 2016

Added i18n strings to view metadata page. This does not include AutoForm label translations, as that currently seems non-trivial.

@brylie
Copy link
Contributor Author

brylie commented Feb 2, 2016

@elnzv will you please review thie PR?

@55 55 self-assigned this Feb 2, 2016
@55 55 added this to the Sprint 22 milestone Feb 2, 2016
@@ -98,6 +98,14 @@
"view_ApiBackend_ExportYaml": "Export .yaml",
"view_ApiBackend_Metadata_Title": "Metadata",
"view_ApiBackend_Metadata_NotFound": "No metadata found.",
"view_ApiBackend_Metadata_Organization_title": "Organization",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add those strings to Finnish translation file as well.

@brylie
Copy link
Contributor Author

brylie commented Feb 3, 2016

It may not be necessary to add the translation strings, containing English text, to the fi.i18n.json. Did you read somewhere that this is a requirement? Is this causing any bug?

@55
Copy link
Contributor

55 commented Feb 4, 2016

@brylie, no, that is not a requirement, but just more comfortable to translate, no need to search for new lines in en.json.

Anyway, I added those myself, resolved conflicts.
Merging.

55 pushed a commit that referenced this pull request Feb 4, 2016
@55 55 merged commit 390364b into develop Feb 4, 2016
@55 55 deleted the feature/api-metadata-i18n branch February 4, 2016 07:50
@55 55 removed the in progress label Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants