'Reset all' in 'Filter' not working, closes #676 #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apinf/developers please review |
| @@ -7,7 +7,7 @@ <h3 class="box-title">{{_ "filterData_Title"}}</h3> | |||
| <div class="box-body"> | |||
| <form id="filteringForm"> | |||
| {{_ "filterData_Month"}} | |||
| <select name="month" > | |||
| <select id="month" name="month" > | |||
There was a problem hiding this comment.
Perhaps prefix these IDs with filter-, to be a bit more specific. E.g.
filter-monthfilter-yearfilter-limitfilter-reset
The reason for this is the dashboard HTML may be pretty dense, and may include other elements that could aptly be assigned the month, year, limit, and/or reset IDs.
|
@brylie Requested improvements done. |
brylie
added a commit
that referenced
this pull request
Feb 3, 2016
'Reset all' in 'Filter' not working, closes #676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP