Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/restructure edit api backend form. Closes #799 #860

Merged
merged 27 commits into from
Feb 9, 2016

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Feb 8, 2016

When debugging #799, I realized that authorization logic was being applied in the router. This PR moves the authorization logic to the template, so that we can check for template level subscriptions when authorizing users.

Additionally, this is a significant restructuring of the editApiBackend template:

  • renamed/restructured files and folders
    • handle subscription in parent template
      • pass in named data context to sub-template
    • all camel case file names for consistency and sorting
    • short and semantic sub-directories (add/edit)
  • removed 'add api backend (advanced)' feature
    • removed unused route
    • form type (insert or update) helper removed

@brylie brylie removed the WIP label Feb 8, 2016
@brylie
Copy link
Contributor Author

brylie commented Feb 8, 2016

@apinf/developers please review.

55 pushed a commit that referenced this pull request Feb 9, 2016
…nd-form

Feature/restructure edit api backend form. Closes #799
@55 55 merged commit 42b083c into develop Feb 9, 2016
@55 55 deleted the feature/restructure-edit-api-backend-form branch February 9, 2016 10:29
@55
Copy link
Contributor

55 commented Feb 9, 2016

Looks good, merging.

@55 55 removed the in progress label Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants