Feature/cleanup config file #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frenchbread is this ready for review? |
|
@brylie Yes. Please review. |
| @@ -12,7 +12,7 @@ Meteor.methods({ | |||
|
|
|||
| // Send the e-mail | |||
| Email.send({ | |||
| to: Settings.findOne().contactForm_toEmail, | |||
| to: Settings.findOne().contactForm.toEmail, | |||
There was a problem hiding this comment.
What happens if this setting is not present? E.g. if the contact form 'to email' has not been provided in the settings collection? I suspect we will get an exception, which needs to be prevented or handled here.
There was a problem hiding this comment.
Should we check if there is a value set in settings and if not, use email address from settings.json
This was referenced Jun 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
Changes