update filter usage

apioo · Sep 17, 2022 · 2d1085d · 2d1085d
1 parent 81c581d
commit 2d1085d
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/src/Console/Generate/SdkCommand.php b/src/Console/Generate/SdkCommand.php
@@ -87,7 +87,14 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         $config = $this->getConfig($input);
-        $filter = $this->getFilter($input);
+        $filter = null;
+        $filterName = $input->getOption('filter');
+        if (!empty($filterName)) {
+            $filter = $this->filterFactory->getFilter($filterName);
+            if ($filter === null) {
+                throw new \RuntimeException('Provided an invalid filter name');
+            }
+        }
 
         $generator = $this->factory->getGenerator($format, $config);
         $extension = $this->factory->getFileExtension($format, $config);
@@ -119,22 +126,16 @@ protected function execute(InputInterface $input, OutputInterface $output)
         return 1;
     }
 
-    private function getConfig(InputInterface $input): string
+    private function getConfig(InputInterface $input): ?string
     {
         $namespace = $input->getOption('namespace');
         $options = [];
         if (!empty($namespace)) {
             $options['namespace'] = $namespace;
         }
 
-        return http_build_query($options);
-    }
-
-    private function getFilter(InputInterface $input): ?FilterInterface
-    {
-        $filterName = $input->getOption('filter');
-        if (!empty($filterName)) {
-            return $this->filterFactory->getFilter($filterName);
+        if (!empty($options)) {
+            return http_build_query($options);
         } else {
             return null;
         }