use post instead of get as webhook

apioo · Jul 16, 2023 · c740a33 · c740a33
1 parent 5f6073b
commit c740a33
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 23 deletions.
diff --git a/src/Installation/NewInstallation.php b/src/Installation/NewInstallation.php
@@ -1690,7 +1690,7 @@ private static function getOperations(): array
                 ),
                 'payment.webhook' => new Operation(
                     action: System\Action\Payment\Webhook::class,
-                    httpMethod: 'GET',
+                    httpMethod: 'POST',
                     httpPath: '/payment/:provider/webhook',
                     httpCode: 200,
                     outgoing: Model\Common\Message::class,

diff --git a/tests/System/Api/Payment/WebhookTest.php b/tests/System/Api/Payment/WebhookTest.php
@@ -39,29 +39,22 @@ public function getDataSet(): array
 
     public function testGet()
     {
-        $response = $this->sendRequest('/system/payment/paypal/webhook', 'GET', array(
-            'User-Agent'    => 'Fusio TestCase',
-        ));
+        $response = $this->sendRequest('/system/payment/paypal/webhook', 'GET', [
+            'User-Agent' => 'Fusio TestCase',
+        ]);
 
-        $body   = (string) $response->getBody();
-        $expect = <<<'JSON'
-{
-    "success": true,
-    "message": "Execution successful"
-}
-JSON;
+        $body = (string) $response->getBody();
 
-        $this->assertEquals(200, $response->getStatusCode(), $body);
-        $this->assertJsonStringEqualsJsonString($expect, $body, $body);
+        $this->assertEquals(404, $response->getStatusCode(), $body);
     }
 
     public function testPost()
     {
-        $response = $this->sendRequest('/system/payment/paypal/webhook', 'GET', array(
-            'User-Agent'    => 'Fusio TestCase',
-        ));
+        $response = $this->sendRequest('/system/payment/paypal/webhook', 'POST', [
+            'User-Agent' => 'Fusio TestCase',
+        ]);
 
-        $body   = (string) $response->getBody();
+        $body = (string) $response->getBody();
         $expect = <<<'JSON'
 {
     "success": true,
@@ -75,9 +68,9 @@ public function testPost()
 
     public function testPut()
     {
-        $response = $this->sendRequest('/system/payment/paypal/webhook', 'PUT', array(
-            'User-Agent'    => 'Fusio TestCase',
-        ), json_encode([
+        $response = $this->sendRequest('/system/payment/paypal/webhook', 'PUT', [
+            'User-Agent' => 'Fusio TestCase',
+        ], json_encode([
             'foo' => 'bar',
         ]));
 
@@ -88,9 +81,9 @@ public function testPut()
 
     public function testDelete()
     {
-        $response = $this->sendRequest('/system/payment/paypal/webhook', 'DELETE', array(
-            'User-Agent'    => 'Fusio TestCase',
-        ));
+        $response = $this->sendRequest('/system/payment/paypal/webhook', 'DELETE', [
+            'User-Agent' => 'Fusio TestCase',
+        ]);
 
         $body = (string) $response->getBody();