Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development dependecies should be standard dependecies #78

Closed
Systho opened this issue Jan 23, 2013 · 3 comments
Closed

Development dependecies should be standard dependecies #78

Systho opened this issue Jan 23, 2013 · 3 comments

Comments

@Systho
Copy link

Systho commented Jan 23, 2013

in the gemspec, the following bloc

  s.add_development_dependency "rspec-rails"
  s.add_development_dependency "rails", ">= 3.0.10"
  s.add_development_dependency "sqlite3"
  s.add_development_dependency "minitest"
  s.add_development_dependency "maruku"
  s.add_development_dependency "RedCloth"
  s.add_development_dependency "rake"
  s.add_development_dependency "rest-client"
  s.add_development_dependency "oauth"

should be replaced by

  s.add_development_dependency "rspec-rails"
  s.add_dependency "rails", ">= 3.0.10"
  s.add_development_dependency "sqlite3"
  s.add_development_dependency "minitest"
  s.add_dependency "maruku"
  s.add_dependency "RedCloth"
  s.add_development_dependency "rake"
  s.add_dependency "rest-client"
  s.add_dependency "oauth"

since most of those gems are production dependecies and not dev dependecies

@Systho
Copy link
Author

Systho commented Jan 23, 2013

I'm not sure about maruku and RedCloth, though.
The readme clearly states that those gems are optional so I guess they can stay dev dependencies

@iNecas
Copy link
Member

iNecas commented Jan 23, 2013

That's right, rest-client and oauth can be removed completly since #74, I agree with rails dep.

@iNecas iNecas mentioned this issue Jan 23, 2013
@iNecas
Copy link
Member

iNecas commented Jan 25, 2013

New release 0.0.14 shouldn't have the problems with implicit oauth and rest-client deps. Closing. Please reopen if needed

@iNecas iNecas closed this as completed Jan 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants