Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cok-Userbot (Sourcery refactored) #73

Open
wants to merge 8 commits into
base: King-Userbot
Choose a base branch
from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Sep 17, 2021

Pull Request #72 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/apisuserbot/King-Userbot pull/72/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

Comment on lines 269 to 272
first_msg_valid = True if msg_info and msg_info.messages and msg_info.messages[
0].id == 1 else False
first_msg_valid = bool(msg_info and msg_info.messages and msg_info.messages[
0].id == 1)
# Same for msg_info.users
creator_valid = True if first_msg_valid and msg_info.users else False
creator_valid = bool(first_msg_valid and msg_info.users)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function fetch_info refactored with the following changes:

@@ -427,7 +426,6 @@ async def _(event):
))
except Exception as e:
await event.reply(str(e))
await event.edit("`Sukses Menambahkan Pengguna Ke Obrolan`")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function _ refactored with the following changes:

Comment on lines -42 to +44
f"**◑» Perintah Plugin** \n\n"
f"**Contoh : Ketik** `.help afk` **Untuk Informasi Pengunaan Plugin Afk\nAtau Bisa Juga Ketik** `.helpme` **Untuk Help Button Lain-Nya** \n\n"
f"**USERBOT TELEGRAM** ")
'**◑» Perintah Plugin** \n\n**Contoh : Ketik** `.help afk` **Untuk Informasi Pengunaan Plugin Afk\nAtau Bisa Juga Ketik** `.helpme` **Untuk Help Button Lain-Nya** \n\n**USERBOT TELEGRAM** '
)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function help refactored with the following changes:

Signed-off-by: apisuserbot <nafisqurtubi154@gmail.com>
@sourcery-ai
Copy link
Author

sourcery-ai bot commented Sep 17, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.78%.

Quality metrics Before After Change
Complexity 22.17 😞 22.00 😞 -0.17 👍
Method Length 71.52 🙂 77.98 🙂 6.46 👎
Working memory 14.98 😞 15.11 😞 0.13 👎
Quality 56.88% 🙂 56.10% 🙂 -0.78% 👎
Other metrics Before After Change
Lines 863 809 -54
Changed files Quality Before Quality After Quality Change
userbot/modules/chat.py 42.46% 😞 42.68% 😞 0.22% 👍
userbot/modules/help.py 56.87% 🙂 66.11% 🙂 9.24% 👍
userbot/modules/king.py 93.06% ⭐ % %
userbot/modules/salam.py 94.42% ⭐ 94.42% ⭐ 0.00%
userbot/modules/www.py 73.00% 🙂 72.80% 🙂 -0.20% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
userbot/modules/chat.py fetch_info 78 ⛔ 877 ⛔ 40 ⛔ 0.80% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userbot/modules/chat.py _ 21 😞 111 🙂 10 😞 48.93% 😞 Refactor to reduce nesting. Extract out complex expressions
userbot/modules/www.py speedtst 0 ⭐ 128 😞 22 ⛔ 52.05% 🙂 Try splitting into smaller methods. Extract out complex expressions
userbot/modules/chat.py get_chatinfo 20 😞 124 😞 8 🙂 52.25% 🙂 Refactor to reduce nesting. Try splitting into smaller methods
userbot/modules/www.py get_readable_time 8 ⭐ 109 🙂 10 😞 59.95% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants