Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: auto use browser language" #1166

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Revert "feat: auto use browser language" #1166

merged 1 commit into from
Aug 1, 2023

Conversation

wangkailang
Copy link
Collaborator

Reverts #1152

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023 •
edited

Image description CodeRabbit

Notes

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @coderabbitai: ignore anywhere in the PR description to ignore further reviews from the bot.

github-actions[bot]
github-actions bot reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 08244b5 and 2d306d0 commits.
Files selected (1)
  • packages/core/src/exports/i18n/index.ts (1)
Files skipped from review due to trivial changes (1)
  • packages/core/src/exports/i18n/index.ts
Review comments generated (0)
  • Review: 0
  • LGTM: 0

@wangkailang wangkailang merged commit 990f3c3 into develop Aug 1, 2023
19 checks passed
@wangkailang wangkailang deleted the revert-1152-feat/use_browser_language branch August 1, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@ranglang ranglang Awaiting requested review from ranglang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wangkailang