Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/robot rich test #1175

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Feature/robot rich test #1175

merged 3 commits into from
Aug 4, 2023

Conversation

ranglang
Copy link
Collaborator

@ranglang ranglang commented Aug 2, 2023

修复机器人跨Action 拷贝

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Image description CodeRabbit


Notes

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @coderabbitai: ignore anywhere in the PR description to ignore further reviews from the bot.

Support us :)

If you like this project, please support us by purchasing the Pro version! The Pro version has advanced context and several proprietary improvements compared to the open source version.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 016760b and 9bd0c61 commits.
Files selected (4)
  • packages/datasheet/src/pc/components/robot/robot_detail/magic_variable_container/helper.ts (3)
  • packages/datasheet/src/pc/components/robot/robot_detail/magic_variable_container/magic_text_field.tsx (2)
  • packages/datasheet/src/pc/components/robot/robot_detail/magic_variable_container/magic_variable_element.tsx (2)
  • packages/datasheet/src/pc/components/robot/robot_detail/select.tsx (1)
Files ignored due to filter (2)
  • packages/datasheet/package.json
  • yarn.lock
Files not reviewed due to errors (3)
  • packages/datasheet/src/pc/components/robot/robot_detail/select.tsx (no response)
  • packages/datasheet/src/pc/components/robot/robot_detail/magic_variable_container/magic_text_field.tsx (no response)
  • packages/datasheet/src/pc/components/robot/robot_detail/magic_variable_container/helper.ts (no response)
Files skipped from review due to trivial changes (1)
  • packages/datasheet/src/pc/components/robot/robot_detail/magic_variable_container/magic_variable_element.tsx
Review comments generated (0)
  • Review: 0
  • LGTM: 0

// console.log('3.Form input init value', props.value);
const triggerId = originalNodeOutputSchemaList?.[0]?.id;

const editor = useMemo(() => withHistory(withMagicVariable(withReact(createEditor() as ReactEditor), triggerId)), []);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useMemo has a missing dependency: 'triggerId'. Either include it or remove the dependency array.
@JaneSu JaneSu merged commit c33a1cd into develop Aug 4, 2023
20 checks passed
@JaneSu JaneSu deleted the feature/robot-rich-test branch August 4, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants