Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: widget-sdk pkg with js files #1362

Merged
merged 4 commits into from
Oct 7, 2023
Merged

Conversation

wangkailang
Copy link
Collaborator

Submit a pull request for this project.

Why?

What?

How?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Image description CodeRabbit


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between feaf33f and bdbac2f commits.
Files selected (1)
  • Makefile (1)
Files ignored due to filter (2)
  • packages/datasheet/package.json
  • pnpm-lock.yaml
Files not summarized due to errors (1)
  • Makefile (nothing obtained from openai)
Files not reviewed due to errors (1)
  • Makefile (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@wangkailang wangkailang merged commit e630e01 into develop Oct 7, 2023
12 of 14 checks passed
@wangkailang wangkailang deleted the fix/widget-sdk-with-js branch October 7, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants