chore: performance profiling tools #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yort-feng
approved these changes
Jan 9, 2023
arucil
added a commit
that referenced
this pull request
Feb 3, 2023
Submit a pull request for this project. <!-- If you have an Issue that related to this Pull Request, you can copy this Issue's description --> # Why? <!-- > Related to which issue? > Why we need this pull request? > What is the user story for this pull request? --> # What? Add Clinic.js to room-server for performance profiling during local development. For example, `make run-perf -> 1` will run room-server with Clinic.js with flamegraph, when room-server is terminated with Ctrl+C, Clinic.js will generate a flamegraph like below.  # How? <!-- > Do you have a simple description of how this pull request is implemented? -->
wumanho
pushed a commit
to wumanho/apitable
that referenced
this pull request
Feb 6, 2023
Submit a pull request for this project. <!-- If you have an Issue that related to this Pull Request, you can copy this Issue's description --> # Why? <!-- > Related to which issue? > Why we need this pull request? > What is the user story for this pull request? --> # What? Add Clinic.js to room-server for performance profiling during local development. For example, `make run-perf -> 1` will run room-server with Clinic.js with flamegraph, when room-server is terminated with Ctrl+C, Clinic.js will generate a flamegraph like below.  # How? <!-- > Do you have a simple description of how this pull request is implemented? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request for this project.
Why?
What?
Add Clinic.js to room-server for performance profiling during local development. For example,
make run-perf -> 1will run room-server with Clinic.js with flamegraph, when room-server is terminated with Ctrl+C, Clinic.js will generate a flamegraph like below.How?