Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix existing unidir link & APITable support to reset password & timezone adjust #382

Merged
merged 11 commits into from
Feb 15, 2023

Conversation

mr-kelly
Copy link
Contributor

@mr-kelly mr-kelly commented Feb 15, 2023

No description provided.

arucil and others added 10 commits February 15, 2023 08:40
Submit a pull request for this project.

<!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 -->

# Why? 
<!-- 
> 对应哪个issue?
> 为什么要这个pull request?
> 背景故事或原因是怎样的?
> 你理解的业务需求是怎样的? 
-->


# What?
<!-- 
> 这是一个什么Pull Request?
> 描述一下是什么?
> 对哪些人有好处? 
-->


# How?
<!-- 
> 大概描述下,如何具体实现的这个Pull Request? 
-->
Fixes core unit test errors caused by circular dependencies.
Submit a pull request for this project.

<!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 -->

# Why? 
<!-- 
> 对应哪个issue?
> 为什么要这个pull request?
> 背景故事或原因是怎样的?
> 你理解的业务需求是怎样的? 
-->


# What?
<!-- 
> 这是一个什么Pull Request?
> 描述一下是什么?
> 对哪些人有好处? 
-->


# How?
<!-- 
> 大概描述下,如何具体实现的这个Pull Request? 
-->
Submit a pull request for this project.

<!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 -->

# Why? 
<!-- 
> 对应哪个issue?
> 为什么要这个pull request?
> 背景故事或原因是怎样的?
> 你理解的业务需求是怎样的? 
-->


# What?
<!-- 
> 这是一个什么Pull Request?
> 描述一下是什么?
> 对哪些人有好处? 
-->


# How?
<!-- 
> 大概描述下,如何具体实现的这个Pull Request? 
-->
## 问题描述
本地 ts 类型没问题

![image](https://user-images.githubusercontent.com/6942517/218973532-ade8ed8d-12f5-494f-836a-46671fba3d0e.png)
但是 ci dayjs  plugin 检查错误:

https://github.com/vikadata/vikadata/actions/runs/4181774162/jobs/7244067412

![image](https://user-images.githubusercontent.com/6942517/218973105-920a5035-d400-4d78-bf34-a1cdde9a57fb.png)

## 解决方案
直接使用原生方案获取时区


# How?
<!-- 
> 大概描述下,如何具体实现的这个Pull Request? 
-->
@mr-kelly mr-kelly changed the title sync: cloud fix feat: fix existing unidir link & APITable support to reset password & timezone adjust Feb 15, 2023
@mr-kelly mr-kelly merged commit 1585653 into develop Feb 15, 2023
@mr-kelly mr-kelly deleted the sync/hosted branch February 15, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants