Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add property based tests to DataBus (#140) #467

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

ziqiangai
Copy link
Contributor

Submit a pull request for this project.

Why?

For the issue #140
Use fast-check.js to simply test the two commands of DataBus to test whether the test quality of DataBus can be improved.

What?

I modified the SaveOps logic of MockDataLoadersaver.

At the same time, a test script is added. If the test code is valid, we can expand the test of DataBus on the basis of this.

To explain, the old pull request was closed because I accidentally deleted the code branch, so now I created a new pull request.

@@ -0,0 +1,121 @@
import { MockDataBus, resetDataLoader } from 'databus/__tests__/mock.databus';
import { ResourceType } from 'types';
import { CollaCommandName, } from 'commands';

Check warning

Code scanning / ESLint

require or disallow trailing commas

Unexpected trailing comma.
@arucil arucil added the enhancement New feature or request label Feb 27, 2023
@arucil arucil merged commit 4f5a0e3 into apitable:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants