Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PHP & Python SDKs test #224

Merged
merged 9 commits into from
Jun 20, 2024
Merged

[WIP] PHP & Python SDKs test #224

merged 9 commits into from
Jun 20, 2024

Conversation

dawkaka
Copy link
Contributor

@dawkaka dawkaka commented Jun 19, 2024

Closes #

How to test

Checklist

  • Make sure you have described your changes and added all relevant screenshots or data.
  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes (or request one from the team).
  • You are NOT deprecating/removing a feature.

Copy link

cloudflare-pages bot commented Jun 19, 2024

Deploying apitoolkit with  Cloudflare Pages  Cloudflare Pages

Latest commit: 11ddbbc
Status: ✅  Deploy successful!
Preview URL: https://4d1dd250.apitoolkit.pages.dev
Branch Preview URL: https://php.apitoolkit.pages.dev

View logs

Copy link
Contributor

@BolajiAyodeji BolajiAyodeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, man.

I made some changes, specifically I removed the optional arguments in the snippets of monitoring requests to stay consistent with the nodejs SDKs (remember you introduced that there).

@BolajiAyodeji BolajiAyodeji merged commit 16629b2 into master Jun 20, 2024
1 check passed
@BolajiAyodeji BolajiAyodeji deleted the php branch June 20, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants