Skip to content

Commit

Permalink
Fix major regression in D3D tracing.
Browse files Browse the repository at this point in the history
We don't keep reference count in the interface wrappers. Furthermore,
calling the interface wrapper's AddRef method inside other methods leads
to corrupted traces.
  • Loading branch information
jrfonseca committed Mar 13, 2012
1 parent ef0c697 commit ed58f5d
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions trace.py
Expand Up @@ -542,8 +542,6 @@ def implementWrapperInterfaceMethodBody(self, interface, base, method):
def wrapIid(self, riid, out):
print ' if (%s && *%s) {' % (out.name, out.name)
print ' if (*%s == m_pInstance) {' % (out.name,)
print ' AddRef();'
print ' m_pInstance->Release();'
print ' *%s = this;' % (out.name,)
print ' }'
for iface in self.api.getAllInterfaces():
Expand Down

0 comments on commit ed58f5d

Please sign in to comment.