Assertion in Parser::parse_value()

[chehrlic]

After reading zrushin's blog I did a short and quick test. All seemed to work fine but a replay (and qapitrace & others) are failing with an assertion in Parser::parse_value(): "error: unknown type -1".
Removing the assert and returning 0 solves the problem - the replay works fine until the end.
Here the bt:

...
42951 glPolygonMode(face = GL_FRONT, mode = GL_FILL)

Breakpoint 1, Trace::Parser::parse_value (this=0x7fffffffda80) at /home/chehrlic/tds/apitrace/trace_parser.cpp:246
246 std::cerr << "error: unknown type " << c << "\n";
(gdb) bt
#0 Trace::Parser::parse_value (this=0x7fffffffda80) at /home/chehrlic/tds/apitrace/trace_parser.cpp:246
#1 0x000000000041408a in Trace::Parser::parse_array (this=0x7fffffffda80) at /home/chehrlic/tds/apitrace/trace_parser.cpp:323
#2 0x00000000004139e6 in Trace::Parser::parse_value (this=0x7fffffffda80) at /home/chehrlic/tds/apitrace/trace_parser.cpp:238
#3 0x0000000000413866 in Trace::Parser::parse_arg (this=0x7fffffffda80, call=0x874ca0)

at /home/chehrlic/tds/apitrace/trace_parser.cpp:205

#4 0x00000000004137d2 in Trace::Parser::parse_call_details (this=0x7fffffffda80, call=0x874ca0)

at /home/chehrlic/tds/apitrace/trace_parser.cpp:187

#5 0x00000000004135fc in Trace::Parser::parse_enter (this=0x7fffffffda80) at /home/chehrlic/tds/apitrace/trace_parser.cpp:154
#6 0x00000000004133aa in Trace::Parser::parse_call (this=0x7fffffffda80) at /home/chehrlic/tds/apitrace/trace_parser.cpp:104
#7 0x000000000041035f in main (argc=2, argv=0x7fffffffdc18) at /home/chehrlic/tds/apitrace/tracedump.cpp:45

git revision e4397f1

[zackr]

Any chance to see the trace file? If not then if you could just post the value of call->sig->name (e.g. p call->sig->name.c_str()) in Trace::Parser::parse_call_details at trace_parser.cpp:187 then that should allow us to fix it quickly.

[chehrlic]

I would rather not post the file in the bugtracker - private mail should be ok if you need it. I wrote you a message through github with my address if you need it.

#4 0x00000000004726ba in Trace::Parser::parse_call_details (this=0x7fffe41b4c80, call=0x7fffdd2cfb30)
at /home/chehrlic/tds/apitrace/trace_parser.cpp:187
187 parse_arg(call);
(gdb) p call->sig->name.c_str()
$1 = 0x7fffdd218058 "glLoadMatrixd"

And two frames below:
#1 0x0000000000472f72 in Trace::Parser::parse_array (this=0x7fffe41b4c80) at /home/chehrlic/tds/apitrace/trace_parser.cpp:323
323 array->values[i] = parse_value();
(gdb) p len
$6 = 16
(gdb) p i
$7 = 6

[chehrlic]

Pushed the wrong button :)

[chehrlic]

Ok, I think I've found the problem. To exit the application I simply killed it by pressing STRG+C. This leads to a corrupted gzip-file.
Imho the assert() should not be there when the file pointer is at EOF - this should fix the issue

[jrfonseca]

It should be fixed now. Thanks for investigating this.