Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict BooleanType #53

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Strict BooleanType #53

merged 1 commit into from
Sep 21, 2018

Conversation

mabar
Copy link
Contributor

@mabar mabar commented Sep 17, 2018

Less magic, more strictness!

@mabar mabar requested a review from f3l1x September 17, 2018 08:40
lulco
lulco reviewed Sep 17, 2018
View reviewed changes
.docs/README.md Outdated
- Converts `'true'` and `'1'` to `true`
- and `false` and `0` to `false`
- Converts `'true'` to `true`
- and `false` to `false`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'false'

@f3l1x f3l1x merged commit 72a4efa into master Sep 21, 2018
@f3l1x f3l1x deleted the strict-boolean-type branch September 21, 2018 09:12
@f3l1x f3l1x added feature and removed feature labels Oct 3, 2018
@f3l1x f3l1x added this to the v0.4 milestone Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lulco lulco lulco left review comments

@f3l1x f3l1x Awaiting requested review from f3l1x

Assignees
No one assigned
Labels
feature
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mabar @lulco @f3l1x