Support only mustache 1.x #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are correct: the limitation of mustache to 0.7.x was a mistake, due to my not being very familiar with the gemspec format. 2015 seems like plenty of time for mustache 1.x to become generally available. This PR seems like the way to go. I'll play around with it a bit and merge. |
|
Thanks @apjanke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
ronngem, supported mustache versions higher that 1.0. However, the currentronn-ngversion does not.I tried running tests using mustache 1, and they run just fine, so I believe not allowing mustache 1 was done unintentionally in b21765c.
Normally, I would restore the original
ronnconstraint (>= 0.7.0), but since mustache 1.0 was release back in 2015, I figured it could be a good opportunity to drop support for old mustache versions too.Just let me know which option you prefer and I'll update the PR.