bug(core/playback/mpv): jukebox mode under windows - navidrome#2767

Use named pipe for socket path under windows during mpv playback, change function name, unexport function

Signed-off-by: apkatsikas <apkatsikas@gmail.com>

core/playback/mpv/mpv.go

@@ -10,6 +10,7 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"sync"
 
@@ -134,9 +135,16 @@ var (
 	mpvErr  error
 )
 
-func TempFileName(prefix, suffix string) string {
+func randomSocketName(prefix, suffix string) string {
 	randBytes := make([]byte, 16)
-	// we can savely ignore the return value since we're loading into a precreated, fixedsized buffer
+	// we can saely ignore the return value since we're loading into a precreated, fixedsized buffer
 	_, _ = rand.Read(randBytes)
-	return filepath.Join(os.TempDir(), prefix+hex.EncodeToString(randBytes)+suffix)
+
+	socketPath := os.TempDir()
+	// Windows needs to use a named pipe instead of a file for the socket
+	// see https://mpv.io/manual/master#using-mpv-from-other-programs-or-scripts
+	if runtime.GOOS == "windows" {
+		socketPath = `\\.\pipe\mpvsocket`
+	}
+	return filepath.Join(socketPath, prefix+hex.EncodeToString(randBytes)+suffix)
 }

core/playback/mpv/track.go

@@ -31,7 +31,7 @@ func NewTrack(playbackDoneChannel chan bool, deviceName string, mf model.MediaFi
 		return nil, err
 	}
 
-	tmpSocketName := TempFileName("mpv-ctrl-", ".socket")
+	tmpSocketName := randomSocketName("mpv-ctrl-", ".socket")
 
 	args := createMPVCommand(mpvComdTemplate, deviceName, mf.Path, tmpSocketName)
 	exe, err := start(args)