search nuclei via id and seg id + caching #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxenes1
requested changes
Nov 30, 2022
| df.to_pickle(settings.STATIC_ROOT+'/'+supported_tables.get(table_type)+'.pkl') | ||
| return df | ||
| else: | ||
| return float('NaN') |
There was a problem hiding this comment.
I think returning False or raising an exception would be better here. When this function is called when can then make sure its returned something by just pass an if statement to it (which would work with this code right now too but a direct False would be more readable IMO
There was a problem hiding this comment.
I updated it to log the error of querying a resource table that does not exist -- happy to adjust it, though, if there are cases you can think of where this would be an undesirable response to a table not being queryable !
dxenes1
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #367 Users can now enter any combination of nuclei and/or seg-ids to search nuclei and neuron types.
New column added to nuclei viewer table to cross-search between seg-id and nuclei-id. Input ids that are not found in the neuron table will be listed below for awareness.
Nuclei and neuron type tables are now also cached in static files for the nuclei states.