Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add float comparison tolerance parameters to freetext directive #159

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ihalaij1
Copy link
Contributor

@ihalaij1 ihalaij1 commented Apr 3, 2023

Description

What?

Add float comparison tolerance parameters to the freetext directive, because MOOC-Grader now supports configurable relative and absolute tolerances instead of the previously hardcoded 2% relative tolerance.

Fixes #158

Testing

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Tested that these changes work with the new changes in MOOC-Grader

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

@ihalaij1 ihalaij1 self-assigned this Apr 3, 2023
directives/questionnaire.py Outdated Show resolved Hide resolved
@PasiSa PasiSa self-assigned this May 9, 2023
Copy link
Contributor

@PasiSa PasiSa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (although I haven't played with rst-tools much). In my opinion we could merge this at the same time with the related grader PR.

Copy link
Collaborator

@markkuriekkinen markkuriekkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@markkuriekkinen markkuriekkinen merged commit 6306927 into apluslms:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add float comparison tolerance parameters to the freetext directive
3 participants