Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable duplicate submission check #174

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

ihalaij1
Copy link
Contributor

Description

What?

Add option to disable duplicate submission check for individual questionnaires and submit exercises or the whole course.

Why?

Some exercises often expect the submissions to be identical, so always showing the confirmation dialog is unnecessary.

Part of apluslms/a-plus#1076

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Tested that the new feature works as expected.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Part of apluslms/a-plus#1076
Copy link
Collaborator

@markkuriekkinen markkuriekkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@@ -47,6 +47,7 @@ class Questionnaire(ConfigurableExercise):
'reveal-model-solutions': directives.unchanged,
'grading-mode': directives.unchanged,
'autosave': directives.flag,
'disable-duplicate-check': directives.flag,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this option is identical for the questionnaire and submit directives, then could the option be defined in the super class ConfigurableExercise? Well, it doesn't fit under the name and purpose of ConfigurableExercise and there are other old options that have been duplicated for questionnaires and submit exercises. Let's keep it like this then.

@markkuriekkinen markkuriekkinen merged commit f0885a1 into apluslms:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants