Skip to content

Commit

Permalink
Clarify messages on module model solution chapter visibility
Browse files Browse the repository at this point in the history
The messages incorrectly assumed that reveal rules are always
connected to the course module's deadline. There are many
alternative triggers to reveal rules and some of them have
nothing to do with the module deadline.

The message `MODULE_MODEL_ANSWER_VISIBILITY_PERMISSION_DENIED_MSG`
started with the "unfortunately" part that is already included
in the permission class's base message (which is
`EXERCISE_VISIBILITY_PERMISSION_DENIED_MSG`).
Thus, the "unfortunately" part should not be repeated.
  • Loading branch information
markkuriekkinen committed Oct 30, 2023
1 parent be3aafa commit 8f85614
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
8 changes: 3 additions & 5 deletions locale/en/LC_MESSAGES/django.po
Original file line number Diff line number Diff line change
Expand Up @@ -3517,9 +3517,7 @@ msgstr "The assignment is only for external users."

#: exercise/permissions.py
msgid "MODULE_MODEL_ANSWER_VISIBILITY_PERMISSION_DENIED_MSG"
msgstr ""
"Unfortunately you are not permitted to view this content, since it contains "
"model answers to assignments whose deadline has not yet passed."
msgstr "It contains model answers that have not been published yet."

#: exercise/permissions.py
msgid "EXERCISE_ASSISTANT_PERMISSION_DENIED_MSG"
Expand Down Expand Up @@ -4108,8 +4106,8 @@ msgstr "Inspect"
#: exercise/templates/exercise/_user_results.html
msgid "MODULE_MODEL_ANSWER_NOT_VISIBLE"
msgstr ""
"This chapter is hidden, since it contains model answers to assignments whose "
"deadline has not yet passed."
"This chapter is hidden, since it contains model answers that have not been "
"published yet."

#: exercise/templates/exercise/_user_toc.html
#: lti_tool/templates/lti_tool/lti_course.html
Expand Down
9 changes: 3 additions & 6 deletions locale/fi/LC_MESSAGES/django.po
Original file line number Diff line number Diff line change
Expand Up @@ -3528,10 +3528,7 @@ msgstr "Tämä tehtävä on vain oppilaitoksen ulkopuolisille opiskelijoille."

#: exercise/permissions.py
msgid "MODULE_MODEL_ANSWER_VISIBILITY_PERMISSION_DENIED_MSG"
msgstr ""
"Valitettavasti sinulla ei ole oikeutta nähdä tätä sisältöä, sillä se "
"sisältää esimerkkiratkaisuja tehtäviin, joiden määräaika ei ole vielä "
"umpeutunut."
msgstr "Se sisältää esimerkkiratkaisuja, joita ei ole vielä julkaistu."

#: exercise/permissions.py
msgid "EXERCISE_ASSISTANT_PERMISSION_DENIED_MSG"
Expand Down Expand Up @@ -4121,8 +4118,8 @@ msgstr "Tutki"
#: exercise/templates/exercise/_user_results.html
msgid "MODULE_MODEL_ANSWER_NOT_VISIBLE"
msgstr ""
"Tämä luku on piilotettu, sillä se sisältää esimerkkiratkaisuja tehtäviin, "
"joiden määräaika ei ole vielä umpeutunut."
"Tämä luku on piilotettu, sillä se sisältää esimerkkiratkaisuja, joita ei ole "
"vielä julkaistu."

#: exercise/templates/exercise/_user_toc.html
#: lti_tool/templates/lti_tool/lti_course.html
Expand Down

0 comments on commit 8f85614

Please sign in to comment.