Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The next submitter link for manual assessment #1196

Closed
markkuriekkinen opened this issue Jun 12, 2023 · 0 comments · Fixed by #1199
Closed

The next submitter link for manual assessment #1196

markkuriekkinen opened this issue Jun 12, 2023 · 0 comments · Fixed by #1199
Assignees
@EerikSaksi
Labels
area: e-exam Important for electronic exams effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team type: bug This is a bug

Comments

@markkuriekkinen
Copy link
Collaborator

After merging the PR #1167 for the issue #1110, we found bugs in the new implementation. The pull request #1167 includes more comments about the details.

  • The selected next submitter may be such a student who has already received manual grading on a submission other than the latest one. A student should be considered manually graded once any one of his/her submissions has been manually graded. The "next submitter" link should not repeat a student who has been manually graded.
  • The "next submitter" link may repeat the same student who was already being inspected. This happens when the student's earlier submission (but not the latest) has been manually graded even though other students have not received any manual grading.
  • When all students have received manual grading, the "next submitter" link must stop cycling between students like the old implementation had done. The old code has an if statement with the comment "There are no more unassessed submitters". It redirects back to the submission list.

Originally posted by @Mankro in #1167 (review)
@markkuriekkinen markkuriekkinen added type: bug This is a bug area: e-exam Important for electronic exams effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team labels Jun 12, 2023
@markkuriekkinen markkuriekkinen added this to the v1.19 milestone Jun 12, 2023
EerikSaksi added a commit to EerikSaksi/a-plus that referenced this issue Jun 13, 2023
@EerikSaksi
Skip submissions if any have been graded in next submitter view
3faa9c6 
Fixes apluslms#1196
@EerikSaksi EerikSaksi mentioned this issue Jun 13, 2023
Merged
18 tasks
markkuriekkinen pushed a commit to EerikSaksi/a-plus that referenced this issue Jun 16, 2023
@EerikSaksi @markkuriekkinen
Skip submissions if any have been graded in next submitter view
e7872ae 
Fixes apluslms#1196
markkuriekkinen added a commit to markkuriekkinen/a-plus that referenced this issue Jun 18, 2023
@markkuriekkinen
Revert "Sort unassessed exercises by most recent submission"
40cf492 
This reverts commit 0a5d7f5.

The feature for chronological sorting of the submissions in
the `NextUnassessedSubmitterView` is still not working correctly.
Thus, I revert this commit before making a new stable release.

See issues apluslms#1196 and apluslms#1110 and pull requests apluslms#1199 and apluslms#1167.
EerikSaksi added a commit to EerikSaksi/a-plus that referenced this issue Jun 20, 2023
@EerikSaksi
Skip submissions if any have been graded in next submitter view
8766cf3 
Fixes apluslms#1196
@markkuriekkinen markkuriekkinen modified the milestones: v1.19, v1.21 Sep 20, 2023
ihalaij1 pushed a commit to ihalaij1/a-plus that referenced this issue May 7, 2024
@EerikSaksi @ihalaij1
Skip submissions if any have been graded in next submitter view
d20e337 
Fixes apluslms#1196
ihalaij1 pushed a commit to EerikSaksi/a-plus that referenced this issue May 7, 2024
@EerikSaksi @ihalaij1
Skip submissions if any have been graded in next submitter view
6e4d3df 
Fixes apluslms#1196
ihalaij1 pushed a commit to EerikSaksi/a-plus that referenced this issue May 7, 2024
@EerikSaksi @ihalaij1
Skip submissions if any have been graded in next submitter view
9fe9551 
Fixes apluslms#1196
ihalaij1 pushed a commit to EerikSaksi/a-plus that referenced this issue May 7, 2024
@EerikSaksi @ihalaij1
Skip submissions if any have been graded in next submitter view
83459cf 
Fixes apluslms#1196
ihalaij1 pushed a commit that referenced this issue May 7, 2024
@EerikSaksi @ihalaij1
Skip submissions if any have been graded in next submitter view
59606cf 
Fixes #1196
@ihalaij1 ihalaij1 removed this from the v1.21 milestone May 7, 2024
mikaelGusse pushed a commit to mikaelGusse/a-plus that referenced this issue May 23, 2024
@EerikSaksi @mikaelGusse
Skip submissions if any have been graded in next submitter view
d408ffe 
Fixes apluslms#1196
mikaelGusse pushed a commit to mikaelGusse/a-plus that referenced this issue May 24, 2024
@EerikSaksi @mikaelGusse
Skip submissions if any have been graded in next submitter view
9ba745a 
Fixes apluslms#1196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EerikSaksi EerikSaksi

Labels
area: e-exam Important for electronic exams effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team type: bug This is a bug
Projects
A+ sprints
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip submissions if any have been graded in next submitter view EerikSaksi/a-plus
3 participants
@markkuriekkinen @ihalaij1 @EerikSaksi