Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Course archive page does not show "hidden from students" labels #727

Closed
markkuriekkinen opened this issue Nov 27, 2020 · 0 comments · Fixed by #1067
Closed

Course archive page does not show "hidden from students" labels #727

markkuriekkinen opened this issue Nov 27, 2020 · 0 comments · Fixed by #1067
Assignees
@EerikSaksi
Labels
area: user interface User interface issues that are not specifically about navigation or user experience (UX) area: UX teacher User experience and usability for teachers effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers priority: medium Valid issue, good to fix but cannot be scheduled yet requester: team The issue is raised by a person inside the A+ developer team type: bug This is a bug
Projects
Live system
Milestone
v1.17

Comments

@markkuriekkinen
Copy link
Member

markkuriekkinen commented Nov 27, 2020 •
edited

The course archive page does not show the label "hidden from students" on a course card if the course instance has the setting visible_to_students = False. Those labels are useful if the user (like a teacher) can see hidden courses in the list.

The course archive page can be accessed from the A+ front page. It has the URL /archive.
@markkuriekkinen markkuriekkinen added type: bug This is a bug area: user interface User interface issues that are not specifically about navigation or user experience (UX) priority: medium Valid issue, good to fix but cannot be scheduled yet experience: good first issue Good for newcomers area: UX teacher User experience and usability for teachers effort: hours Estimated to take less than one day, from the creation of a new branch to the merging requester: team The issue is raised by a person inside the A+ developer team labels Nov 27, 2020
@markkuriekkinen markkuriekkinen added this to the June 2021 milestone Nov 27, 2020
@markkuriekkinen markkuriekkinen added this to New and unsorted in Live system via automation Nov 27, 2020
@markkuriekkinen markkuriekkinen moved this from New and unsorted to To do in Live system Nov 27, 2020
@markkuriekkinen markkuriekkinen removed this from the June 2021 Release v1.9 milestone Feb 4, 2022
@EerikSaksi EerikSaksi mentioned this issue Aug 31, 2022
Merged
11 tasks
@markkuriekkinen markkuriekkinen mentioned this issue Sep 6, 2022
Closed
@markkuriekkinen markkuriekkinen added this to the v1.17 milestone Sep 6, 2022
EerikSaksi added a commit to EerikSaksi/a-plus that referenced this issue Sep 6, 2022
@EerikSaksi
_course_cards.html doesn't hide label when condensed
64f144a 
Before, when the _course_cards was created by a parent and condensed was
set to true, the hidden label would not be visible. Now condensed cards
also show the label. This was done through removing the "and not
condensed" condition from the card template

Fixes apluslms#727
markkuriekkinen pushed a commit to EerikSaksi/a-plus that referenced this issue Oct 31, 2022
@EerikSaksi @markkuriekkinen
Show the "hidden from students" label on the course archive page
6796b32 
The course archive page and the course instance list
(under one course) did not show the "hidden from students" label
on hidden course instances. This commit fixes that.

The template `_course_cards.html` now always shows the hidden label
when the course instance is hidden. There is no use case when
the label should not be shown on a hidden course.

Fixes apluslms#727
markkuriekkinen pushed a commit that referenced this issue Oct 31, 2022
@EerikSaksi @markkuriekkinen
Show the "hidden from students" label on the course archive page
d43037e 
The course archive page and the course instance list
(under one course) did not show the "hidden from students" label
on hidden course instances. This commit fixes that.

The template `_course_cards.html` now always shows the hidden label
when the course instance is hidden. There is no use case when
the label should not be shown on a hidden course.

Fixes #727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EerikSaksi EerikSaksi

Labels
area: user interface User interface issues that are not specifically about navigation or user experience (UX) area: UX teacher User experience and usability for teachers effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers priority: medium Valid issue, good to fix but cannot be scheduled yet requester: team The issue is raised by a person inside the A+ developer team type: bug This is a bug
Projects
A+ sprints
Status: Done
Live system
  
To do
Milestone
v1.17
Development

Successfully merging a pull request may close this issue.

_course_cards.html doesn't hide label when condensed EerikSaksi/a-plus
2 participants
@markkuriekkinen @EerikSaksi