Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the current course instance redirection when the newest instance is not open yet #919

Closed
markkuriekkinen opened this issue Nov 29, 2021 · 0 comments · Fixed by #1068
Closed
Assignees
Labels
area: navigation Issues related to menus and navigation area: UX student User experience and usability for students effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers requester: CS The issue is raised internally by a CS teacher requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug
Milestone

Comments

@markkuriekkinen
Copy link
Member

The current course instance redirection (URL contains course without any course instance identifier): https://plus.cs.aalto.fi/o1

class LastInstanceView(CourseMixin, BaseRedirectView):

From @jsorva:

In a meeting some time ago, I promised to return to the issue of the
“current instance link” that points to the most recent version of a
course. So, here’s how I’d prefer like it to work:

  1. While a course is running, the link points to the active instance.
    [For O1, this is in during the fall term.]

  2. After a course is over [in December], the link continues to points to
    the most recent instance. This continues even after next year’s instance
    has been created in A+ but isn’t yet open to the public [typically early
    in the next calendar year]. And it even continues after the next
    instance is technically visible in some form but there’s only the front
    page and maybe some other materials, but the actual course contents
    aren’t visible yet [this is often the case during the summer].

  3. Only when the actual course contents are visible [ideally some time
    in August, but might be September] does the link start pointing at the
    new instance.

To summarize, I’d like the link to always point to the newest instance
whose actual contents are actually visible; the mere existence of the
instance isn’t enough. (I’m not sure how close this wish is to the
current behavior.)

Internal ticket: https://rt.cs.aalto.fi/Ticket/Display.html?id=20168


My first hunch is that this should be easy to accomplish by tweaking the latest course instance selection in the LastInstanceView.

@markkuriekkinen markkuriekkinen added area: navigation Issues related to menus and navigation area: UX student User experience and usability for students effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers requester: CS The issue is raised internally by a CS teacher requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug labels Nov 29, 2021
@PasiSa PasiSa added this to the v1.17 milestone Aug 22, 2022
EerikSaksi added a commit to EerikSaksi/a-plus that referenced this issue Sep 20, 2022
By joining the instance with the module, filtering all modules which are ready, and checking if any exist, we can check if there are any public modules. This means that we select the most recent instance with public modules.

Fixes apluslms#919
EerikSaksi added a commit to EerikSaksi/a-plus that referenced this issue Sep 22, 2022
By joining the instance with the module, filtering all modules which are ready,
and checking if any exist, we can check if there are any public modules. This
means that we select the most recent instance with public modules.

Fixes apluslms#919
markkuriekkinen pushed a commit to EerikSaksi/a-plus that referenced this issue Oct 27, 2022
Do not redirect to a course instance that contains only hidden
course modules.

Part of apluslms#919
markkuriekkinen added a commit to EerikSaksi/a-plus that referenced this issue Oct 27, 2022
The redirection to the last course instance looks for a target that
includes course modules that have been opened and that the target
course instance has started.

Fixes apluslms#919
markkuriekkinen pushed a commit that referenced this issue Oct 27, 2022
Do not redirect to a course instance that contains only hidden
course modules.

Part of #919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: navigation Issues related to menus and navigation area: UX student User experience and usability for students effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers requester: CS The issue is raised internally by a CS teacher requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants