Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search select form input do not connect the visible label to the search input #934

Closed
markkuriekkinen opened this issue Dec 10, 2021 · 1 comment
Closed

Search select form input do not connect the visible label to the search input #934

markkuriekkinen opened this issue Dec 10, 2021 · 1 comment
Assignees
@EerikSaksi
Labels
area: accessibility Related to accessibility, e.g., accessibility standards and guidelines area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers requester: team The issue is raised by a person inside the A+ developer team requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug
Milestone
v1.17

Comments

@markkuriekkinen
Copy link
Member

Search select form inputs (like add assistants in the edit course form) do not connect the visible label to the visible search input. The label <label for="id_assistants"> points to the hidden <select id="id_assistants"> element, but for accessibility and usability, the label should connect to the visible search text input with the id. For example, when you click the label, it should focus the text input. This already works with the open and close time fields in the edit course form,

Originally posted by @Mankro in #926 (review)
@markkuriekkinen markkuriekkinen added area: accessibility Related to accessibility, e.g., accessibility standards and guidelines area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers requester: team The issue is raised by a person inside the A+ developer team requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug labels Dec 10, 2021
@markkuriekkinen
Copy link
Member Author

This is the edit course form with the assistants field:

a-plus/edit_course/course_forms.py

Line 78 in 3220547

assistants = UsersSearchSelectField(

@EerikSaksi EerikSaksi mentioned this issue Sep 2, 2022
Closed
12 tasks
EerikSaksi added a commit to EerikSaksi/a-plus that referenced this issue Sep 6, 2022
@EerikSaksi
ajax_search_select.js label refers to the input
355cbe0 
Fixes apluslms#934
@markkuriekkinen markkuriekkinen added this to the v1.17 milestone Oct 11, 2022
@markkuriekkinen markkuriekkinen changed the title Search select form input do not connect the visible label to the seach input Search select form input do not connect the visible label to the search input Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EerikSaksi EerikSaksi

Labels
area: accessibility Related to accessibility, e.g., accessibility standards and guidelines area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers requester: team The issue is raised by a person inside the A+ developer team requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug
Projects
A+ sprints
Status: Done
Milestone
v1.17
Development

Successfully merging a pull request may close this issue.

Clicking the label in a SearchSelectField focuses input EerikSaksi/a-plus
2 participants
@markkuriekkinen @EerikSaksi