Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The response dialog of a submit exercise shows another submission form with delayed feedback #935

Closed
atilante opened this issue Dec 10, 2021 · 6 comments · Fixed by #1072
Assignees
Labels
area: exercises Related to exercises. Use other labels to focus issue to UI/backend area: UX student User experience and usability for students effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate requester: CS The issue is raised internally by a CS teacher type: feature New feature or change to a feature
Milestone

Comments

@atilante
Copy link

atilante commented Dec 10, 2021

When the reveal-submission-feedback is used and a student submits a programming exercise, A+ shows another submission form in the response dialog.

.. submit:: class_y_programming A600
  :config: exercises/programming/exam-y/config.yaml
  :radar_tokenizer: python
  :title: Extending the program code
  :submissions: 5
  :reveal-submission-feedback: deadline +75min

delayed-feedback-bug

I think this is more than a cosmetic bug, because the student can resubmit their file using the submission form inside the response dialog. Thus the student can submit the same file twice by mistake.

I encountered this when testing A+ locally (containers apluslms/run-aplus-front:1.11 and apluslms/run-mooc-grader:1.11).

@atilante
Copy link
Author

One workaround is to have a run.sh grading script that notifies the student that the exercise will be graded later.

#!/bin/bash

# run.sh during exam

title -c "text-primary" "Submission received"

capture echo "<p>Vastauksesi on tallennettu. Tämä tehtävä arvostellaan " \
"tentin jälkeen.</p>" \
"<p>Your answer has been saved. This exercise will be graded after the " \
"examination.</p>"

points 0 10

# Always exit with code 0 to show all error output
exit 0

Then, after the deadline has passed, modify the run.sh script to run the actual exercise grader and resubmit students' submissions manually in A+.

@markkuriekkinen markkuriekkinen added area: exercises Related to exercises. Use other labels to focus issue to UI/backend area: UX student User experience and usability for students effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate requester: CS The issue is raised internally by a CS teacher requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: feature New feature or change to a feature labels Dec 10, 2021
@markkuriekkinen
Copy link
Member

Since the feedback is delayed, A+ renders the exercise description form in place of the feedback in modals that would normally show the feedback. Rendering the original exercise form is especially important for questionnaires since it is the best way to show the contents of the existing submission (to remind the student what has been submitted). In file upload exercises, the form is maybe more confusing and the submitted file is anyway separately linked in the top of the "feedback" modal.

So, you would basically want to remove the exercise form from the (delayed) feedback modal dialogs when the exercise accepts only file submissions. Is that correct?

@atilante
Copy link
Author

Yes, that's correct.

@annirytkonen annirytkonen removed the requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) label Apr 7, 2022
@PasiSa PasiSa added this to the v1.17 milestone Apr 7, 2022
@annirytkonen
Copy link

preliminarily scheduled for autumn 2022 - could you @atilante still specify the schedule of the need! E.g. when the course needing this will run for the next time.

@atilante
Copy link
Author

atilante commented May 5, 2022

I would say the end of August 2022. Ari Korhonen is having another exam for CS-A1141 & CS-A1143 at 10th September as an A+ course (similar to this one).

@markkuriekkinen markkuriekkinen modified the milestones: v1.17, v1.16 May 5, 2022
@markkuriekkinen markkuriekkinen modified the milestones: v1.16, v1.17 Aug 23, 2022
@atilante
Copy link
Author

atilante commented Sep 6, 2022

I and EDIT team discussed today that this issue will be fixed in November for the possibility that CS-A1141 & CS-A1143 Data Structures and Algorithms Y exams 16.12.2022 are at A+.

ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Sep 6, 2022
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Sep 6, 2022
markkuriekkinen pushed a commit to ihalaij1/a-plus that referenced this issue Oct 20, 2022
markkuriekkinen added a commit to ihalaij1/a-plus that referenced this issue Oct 20, 2022
`Submission.load()` does not need to compute `feedback_revealed`
itself since the callers of the method can easily pass the same
value to `Submission.load()`.

Part of apluslms#935
markkuriekkinen added a commit that referenced this issue Oct 20, 2022
`Submission.load()` does not need to compute `feedback_revealed`
itself since the callers of the method can easily pass the same
value to `Submission.load()`.

Part of #935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: exercises Related to exercises. Use other labels to focus issue to UI/backend area: UX student User experience and usability for students effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate requester: CS The issue is raised internally by a CS teacher type: feature New feature or change to a feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants