Remaining submission counter #1168
Conversation
There was a problem hiding this comment.
As said in earlier comment, I think the idea was to count individual submitters, not submissions. Apart from that, I didn't have other comments on code. I also quickly tested this.
I think the other commit was already included in PR #1167 that was merged , so it could be cleaned up. Also remember to rebase against current master, there are also other recent commits.
exercise/staff_views.py
Outdated
| @@ -338,6 +338,8 @@ def get(self, request: HttpRequest, *args: Any, **kwargs: Any) -> HttpResponse: | |||
| ) | |||
| .filter(count_assessed=0)) | |||
|
|
|||
| total_submissions = submissions.count() | |||
There was a problem hiding this comment.
I think the idea was to show the number of submitters remaining, now the counting is done based on submissions. I made four submissions by three different users and it shows X / 4 (and percentage accordingly), but the number of total students should have been 3.
|
Now that I more carefully read the issue description, I understood that the request was to add the counter on the top of the submitters list. Now it is only in the inspect submissions view, which was the other proposal in the issue. Or was it the intent that the idea in issue comment would replace the original proposal? Related to earlier comment, I also noticed that if I manually assess one of the submissions by student with multiple submissions, the other submissions from that student are still counted as unassessed, "Assess next" button also rotates to those once assessed students. |
EerikSaksi
force-pushed
the
remaining-submission-counter
branch
from
3c03300
to
2c4eeea
Compare
|
Here are the three places I added the counter. Any feedback on the formatting or location is welcome |
ihalaij1
force-pushed
the
remaining-submission-counter
branch
2 times, most recently
from
bfbf8ce
to
0cf3323
Compare
Add counter of manually assessed submitters, showing the number of submitters that have been assessed, remaining, and the percentage. Fixes apluslms#1109
ihalaij1
force-pushed
the
remaining-submission-counter
branch
from
0cf3323
to
854f92a
Compare
馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃馃毃This work depends on the PR #1167 which should be merged before this
Description
What?
vid.mp4
Add counter of manually assessed users, showing the number of users that have been passed in the queue, remaining, and the percentage. This ratio and percentage are displayed on the link to assess the next user.
Why?
Gives teachers grading a sense of how much there is to grade, and how much has already been done.
How?
We first get the total number of submissions prior to filtering by time. After filtering by time, we again get the number of submissions to calculate how many submission the user has already viewed. We use these two values to show the ratio and calculate the percentage. We embed this as a session variable, because
NextUnassessedSubmitterViewredirects toInspectSubmissionView, and this allows us to pass this information without modifying the URL pattern.Fixes #1109
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
Ensuring the percentage and ratio of assessed submission is correct.
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!