Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide maintenance-mode content from ToC #1183

Merged
merged 1 commit into from
May 31, 2023

Conversation

ihalaij1
Copy link
Contributor

Description

What?

Course exercises weren't normally listed in the ToC, but they appeared there if they were put into maintenance mode.

Modules' children that are in maintenance mode (LearningObject.status maintenance) are now hidden from the course table of contents. Modules are still shown in ToC even if they are in maintenance mode.

Why?

This change was requested by a teacher.

Fixes #1124
Fixes #438

Testing

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Tested that module children were hidden from ToC if they were put into maintenance mode.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

@ihalaij1 ihalaij1 added this to the Summer 2023 milestone May 30, 2023
@markkuriekkinen markkuriekkinen self-assigned this May 30, 2023
@markkuriekkinen markkuriekkinen self-requested a review May 30, 2023 10:20
@markkuriekkinen markkuriekkinen removed this from the Summer 2023 milestone May 30, 2023
Copy link
Collaborator

@markkuriekkinen markkuriekkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have questions below.

exercise/templates/exercise/_children.html Show resolved Hide resolved
exercise/templates/exercise/_children.html Outdated Show resolved Hide resolved
@ihalaij1 ihalaij1 modified the milestone: Summer 2023 May 30, 2023
@ihalaij1 ihalaij1 assigned markkuriekkinen and unassigned ihalaij1 May 30, 2023
Copy link
Collaborator

@markkuriekkinen markkuriekkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@markkuriekkinen markkuriekkinen merged commit ba02dcc into apluslms:master May 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants